Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2559. Add applying augmentation library tests #2564

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Mar 8, 2024

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have one question: Can we make the language versions explicit in those few tests that are about the language version? It seems slightly dangerous to rely on an implicit language version.

@sgrekhov
Copy link
Contributor Author

Specified language version 3.4. Now the tests check versions 3.3 vs. 3.4. Please take another look

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg eernstg merged commit 5c18c22 into dart-lang:master Mar 11, 2024
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 3, 2024
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting itself tests (dart-lang/co19#2567)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 1 (dart-lang/co19#2568)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add merge order tests (dart-lang/co19#2566)
2024-03-16 sgrekhov22@gmail.com dart-lang/co19#2559. Add augmenting types tests. Part 4 (dart-lang/co19#2571)
2024-03-16 sgrekhov22@gmail.com Fixes dart-lang/co19#2572. Fix roll failures (dart-lang/co19#2573)
2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add applying augmentation library tests (dart-lang/co19#2564)
2024-03-11 sgrekhov22@gmail.com dart-lang/co19#2559. Add tests for augment libraries errors (dart-lang/co19#2562)
2024-03-08 sgrekhov22@gmail.com Fixes dart-lang/co19#2558. Remove `inline-class` experimental flag (dart-lang/co19#2563)

R=kustermann@google.com, pquitslund@google.com

Change-Id: Icdfcf44ecc525c1a673ec8024577cbcdfd316eb0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359440
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Auto-Submit: Sergey Grekhov <sgrekhov22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants