#2643. Remove legacy types from subtyping tests #2652
Conversation
There was a problem hiding this comment.
I can see that all tests except TypeSystem/subtyping/static/test_types/right_object_A03.dart and TypeSystem/subtyping/static/test_types/right_object_fail_A05.dart are clearly concerned with legacy-only features (so it's fine to delete them).
Those remaining two tests, 'right_object_A03' and 'right_object_fail_A05', do not obviously involve any legacy-only features according to their description, but they do use a legacy type X to test the situation in the description. So it should be fine to delete those as well, and there will be other tests testing the same thing with purely null-safe tests.
TypeSystem/subtyping/static/test_types/left_null_fail_A04.dart is tricky because it says 'Check that otherwise, the query is false', and T1 is X, and X is declared in a legacy library. That seems to match the case where T1 is of the form S*.
Pondering this one more time, I think this is OK: A legacy class used as a type in a null-safe library is a null-safe type, not a legacy type.
OK, LGTM!
2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Experimental flag renamed (dart-lang/co19#2655) 2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2641. Add more test cases to the existing wildcard tests (dart-lang/co19#2654) 2024-05-10 sgrekhov22@gmail.com dart-lang/co19#2643. Remove some of 2.6 libraries, update/remove tests using them (dart-lang/co19#2650) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2648) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove tests checking exports from 2.6 libraries (dart-lang/co19#2651) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy types from subtyping tests (dart-lang/co19#2652) 2024-05-08 sgrekhov22@gmail.com dart-lang/co19#2641. Add experimental flag to wildcards tests (dart-lang/co19#2653) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove more legacy tests from LanguageFeatures/nnbd/weak/overriding (dart-lang/co19#2647) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from LanguageFeatures/Generic-functions-as-type-args (dart-lang/co19#2645) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2631. Add tests checking access to local declaration named `_` (dart-lang/co19#2639) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove legacy tests from TypeSystem/type-normalization (dart-lang/co19#2646) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2643. Remove override checking tests in case a legacy class extending an opted-in class (dart-lang/co19#2644) 2024-05-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2638. Add extension methods test for type aliases (dart-lang/co19#2640) 2024-05-07 sgrekhov22@gmail.com dart-lang/co19#2142. Add tests checking type parameter vs representation variable name conflict (dart-lang/co19#2642) 2024-05-03 devoncarew@google.com blast_repo fixes (dart-lang/co19#2637) Change-Id: I3f9f18065b555634b621100bdc375b40a75539cf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365821 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Alexander Thomas <athom@google.com> Reviewed-by: Alexander Thomas <athom@google.com>
No description provided.