New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FunctionType
implement TypeReference
#175
Conversation
Fixes #174 - Add a test which fails before this change and passes after - Add tests for nested function types since that was untested previously - Make `FuctionType` implement `TypeReference`, add missing fields returning null and rebuild the built_value file. - Return `this` from the `type` getter.
Hmm, I don't think we can do this. We can't implement both I'm not sure what the right way forward is. |
What about just loosening whatever is requesting a |
Changing I think, though, that it's a breaking change. Implementations of |
Realistically the only implementation of ... so I'm OK with saying the original implementation was broken, and custom implementations of the visitor/emitter will need a few lines updated to keep working. |
Sounds good. I added a note to the changelog about the breaking change. |
@matanlurey - if you have a chance to publish soon I'd appreciate it 😄 |
@natebosch Definitely today, I'm back home in about an hour. |
Fixes #174
FuctionType
implementTypeReference
, add missing fieldsreturning null and rebuild the built_value file.
this
from thetype
getter.