Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FunctionType implement TypeReference #175

Merged
merged 4 commits into from Nov 27, 2017
Merged

Make FunctionType implement TypeReference #175

merged 4 commits into from Nov 27, 2017

Commits on Nov 26, 2017

  1. Make FunctionType implement TypeReference 

    Fixes #174

- Add a test which fails before this change and passes after
- Add tests for nested function types since that was untested previously
- Make `FuctionType` implement `TypeReference`, add missing fields
  returning null and rebuild the built_value file.
- Return `this` from the `type` getter.
    @natebosch
    natebosch committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    75b6747 View commit details
    Browse the repository at this point in the history

  2. Change type to Reference

    @natebosch
    natebosch committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    0730afb View commit details
    Browse the repository at this point in the history

  3. Change type on visitors

    @natebosch
    natebosch committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    4a8ae5e View commit details
    Browse the repository at this point in the history

  4. Add note about breaking change

    @natebosch
    natebosch committed Nov 26, 2017
    Configuration menu
    Copy the full SHA
    58374f8 View commit details
    Browse the repository at this point in the history