-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for extension types #399
Comments
My initial thought: this package isn't the analyzer. If folks generate invalid code, they will find out statically or at runtime pretty quick. If it's 5% more work to make a separate thing, consider it. If it's 50% more work – or tough to discover, I'd just add a flag to the normal class. Just my opinion. Happy to hear thoughts from others... |
Agreed that we don't need to spend too much effort on keeping usage on the rails. I don't have a strong opinion on whether it's a new class or a field on |
Okay, if people don't have strong feelings, and validation isn't that important, than I think it is easier to just make this a bit. The only argument against making it a bit is that it could provide better validation for users. However, the cost of that benefit is pretty substantial. In addition to being more work to land the feature, it'd also be more work to maintain. Furthermore, there are other class modifiers, i.e. Anyway, we have some time to think about this. I'll try and find the time to put together a CL in the next few weeks and we can discuss things further there. |
I'm going to likely take a crack at this so that we can migrate package:web to extension types. I haven't dug into this package too much to determine if we should just modify |
I'd like to use inline classes in
package:code_builder
.AFAICT there are two approaches we can take:
ClassBuilder
.(1) is more straightforward, and perhaps more discoverable for users. But inline classes are a bit more restricted than regular classes, so I can definitely see an argument for (2).
Thoughts?
CCing @kevmoo @natebosch @matanlurey for feedback.
The text was updated successfully, but these errors were encountered: