Fix a number of issues. #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjbanov
approved these changes
Oct 16, 2017
| @@ -39,15 +39,89 @@ abstract class Expression implements Spec { | |||
| return new BinaryExpression._(toExpression(), other, '&&'); | |||
| } | |||
|
|
|||
| /// This expression preceding by `await`. | |||
| } | ||
|
|
||
| /// Return `{other} = {this}`. | ||
| Expression assign(Expression other) { |
There was a problem hiding this comment.
Hmm, a.assign(b) reads way too much like a = b. Maybe flip the logic and make it {this} = {other}?
Or perhaps rename to assignTo? Although not sure that helps much.
| ); | ||
| } | ||
|
|
||
| /// Return `{other} ??= {this}`. |
There was a problem hiding this comment.
Same issue as the one with assign.
| ); | ||
| } | ||
|
|
||
| /// May be overriden to support other types implementing [Expression]. | ||
| /// Returns a const instance of this expression with a named constructor. |
There was a problem hiding this comment.
I'm not sure what this does. Could you provide an example (and add it to the dartdoc)? Specifically, I'm not aware of many kinds of expressions that you can invoke with a named constructor, i.e. only references to classes. Perhaps this method should be moved to Reference?
| ); | ||
| } | ||
|
|
||
| /// This expression preceding by `return`. |
|
Going to fix some of the comments in the next CL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135.
Closes #136.
Closes #137.
Closes #138.
Closes #139.
This API already exists internally, so I'm skipping tests until we are back in sync - I won't release this asEDIT: Added tests anyway.2.0.0-alpha+3before adding test coverage, though.