Add declareVar/Final/Const #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #343 These utilities serve as a replacement for `assignVar/Final/Const` which have an inverted responsibility - the variable is told about it's assignment, rather than an assignment being told about the variable it is assigned to. Unifies the interaction with `Expression.assign`. Use named instead of positional optional arguments. Add an optional argument for a `late` prefix for the final and var declarations. Const variables may not be `late`. Will deprecate the `assign*` methods in a followup after doing some cleanup of internal usage.
jakemac53
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #343
These utilities serve as a replacement for
assignVar/Final/Constwhichhave an inverted responsibility - the variable is told about it's
assignment, rather than an assignment being told about the variable it
is assigned to. Unifies the interaction with
Expression.assign.Use named instead of positional optional arguments. Add an optional
argument for a
lateprefix for the final and var declarations. Constvariables may not be
late.Will deprecate the
assign*methods in a followup after doing somecleanup of internal usage.