Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DelegatingList: Fails dartanalyzer --strong due to mistype of expand and map #19

Closed
matanlurey opened this issue Feb 5, 2016 · 4 comments

Comments

@matanlurey
Copy link
Contributor

DelegatingList types the methods while dart:core|Iterable does not.

@matanlurey
Copy link
Contributor Author

[error] Base class introduces an invalid override. The type of _DelegatingIterableBase.expand (((E) → Iterable<dynamic>) → Iterable<dynamic>) is not a subtype of Iterable<E>.expand (<T>((E) → Iterable<T>) → Iterable<T>). (/home/ubuntu/workspace/lib/src/observable_list.dart, line 49, col 5)
[error] Base class introduces an invalid override. The type of _DelegatingIterableBase.map (((E) → dynamic) → Iterable<dynamic>) is not a subtype of Iterable<E>.map (<T>((E) → T) → Iterable<T>). (/home/ubuntu/workspace/lib/src/observable_list.dart, line 49, col 5)

@sethladd
Copy link

sethladd commented Feb 5, 2016

cc @kevmoo @leafpetersen

I wonder if we could add --strong to our buildbots to ensure the packages we produce work with strong mode.

@nex3
Copy link
Member

nex3 commented Mar 24, 2016

I'm going to merge this with #23, which @ochafik is actively working on.

@nex3 nex3 closed this as completed Mar 24, 2016
@matanlurey
Copy link
Contributor Author

Thanks Natalie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants