Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrypoUtils is just a placeholder for static methods #7

Closed
DartBot opened this issue Jun 5, 2015 · 4 comments
Closed

CrypoUtils is just a placeholder for static methods #7

DartBot opened this issue Jun 5, 2015 · 4 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/209047?v=3" align="left" width="96" height="96"hspace="10"> Issue by dasmoth
Originally opened as dart-lang/sdk#10217


Any reason why these can't be top-level functions in the dart:crypto package? Didn't Dart add support for top-level functions to avoid this kind of Java-ism?

@DartBot DartBot added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) Priority-Medium labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl


Added Area-Library, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/8631949?v=3" align="left" width="48" height="48"hspace="10"> Comment by floitschG


the dart:crypto library is on my list of libraries that need a facelift (or maybe need to be moved into a pub-package that is independent of the core libraries).


Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/4865287?v=3" align="left" width="48" height="48"hspace="10"> Comment by lrhn


It is now a package.


Removed Area-Library label.
Added Area-Pkg, Pkg-Crypto labels.

@sethladd sethladd added type-enhancement A request for a change that isn't a bug and removed Accepted type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Sep 16, 2015
@kevmoo
Copy link
Member

kevmoo commented Sep 8, 2016

Removed in 9809d9f

@kevmoo kevmoo closed this as completed Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants