Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SDK dependency to 2.12.0-0 #107

Merged
merged 3 commits into from
Nov 26, 2020
Merged

Upgrade SDK dependency to 2.12.0-0 #107

merged 3 commits into from
Nov 26, 2020

Conversation

lrhn
Copy link
Member

@lrhn lrhn commented Nov 23, 2020

Also depend on package:convert 3.0.0-nullsafety.

Also depend on package:convert 3.0.0-nullsafety.
@mit-mit
Copy link
Member

mit-mit commented Nov 23, 2020

What would it take to drop the dependency override on convert?

@mit-mit
Copy link
Member

mit-mit commented Nov 23, 2020

We should update the version (currently version: 2.2.0-nullsafety-dev) to use our recommended format, which I believe would be version: 3.0.0-nullsafety.0?

@lrhn
Copy link
Member Author

lrhn commented Nov 23, 2020

I updated the version number to 3.0.0-nullsafety.0.
Now we need dep-overrides for many more packages (all of those directly or transitively depending on crypto <3.0.0)

Copy link

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natebosch was assigned this package in the sheet so I would wait for his lgtm that this is ready to publish just to double check, otherwise we should leave the version at -nullsafety-dev (or maybe -nullsafety.0-dev?

@lrhn
Copy link
Member Author

lrhn commented Nov 23, 2020

Definitely not ready to publish, so @natebosch, feel free to start from scratch or take over this attempt.

@jakemac53
Copy link

jakemac53 commented Nov 23, 2020

This could still land if we change the version to 2.2.0-nullsafety.0-dev in that case, bumping the sdk constraint LGTM

pubspec.yaml Outdated Show resolved Hide resolved
@mit-mit
Copy link
Member

mit-mit commented Nov 23, 2020

@natebosch @jakemac53 what's the story about the needed dependency override?

@natebosch
Copy link
Member

what's the story about the needed dependency override?

They will be necessary for packages that are making breaking changes are are also circularly dependencies of anything in dev_dependencies like package:test. As long as we don't need overrides for stuff in dependencies it's still OK to publish, and we then can expand the constraints from things that depend on it and remove the override. It sometimes takes a bit of time, but it doesn't introduce much risk.

Co-authored-by: Nate Bosch <nbosch@google.com>
@lrhn lrhn merged commit a5ec902 into master Nov 26, 2020
@mit-mit mit-mit deleted the null-safety-12 branch November 30, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants