Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and version for release #107

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

leonsenft
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes Google CLA signed label Jul 27, 2020
@leonsenft leonsenft requested a review from kevmoo July 27, 2020 17:48
@@ -1,3 +1,7 @@
## 0.17.0

- Added support for escape codes in identifiers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a breaking change? Does it have to be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice no, but I encountered a very peculiar edge case to which this is breaking.

Previously the parser would accept (note the space):

# id {
}

and treat it as

#id {

}

The same goes for class selectors. It would issue a warning for this case, but if you ignored it, this would be valid. However, I'm inclined to consider this a bug fix rather than a breaking change, so I'll drop the version number back down.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful – but not too careful.

Major revs are a pain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to link #106 for context.

@matanlurey
Copy link

We should just blanket move this package into condemned/unsupported/etc and stop worrying about maintaining a CHANGELOG, imo.

@leonsenft leonsenft merged commit 451448a into dart-lang:master Jul 27, 2020
@leonsenft leonsenft deleted the publish branch July 27, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants