New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mdc_web then roll those updates into DartPad #2388
Comments
@johnpryan Looks like holding back sass is going to start causing problems (https://github.com/dart-lang/dart-pad/actions/runs/3481346651/jobs/5822319108). I'm not familiar with the process of updating mdc_web or what is required there. Could you provide some context on how to do so or update it when you get a chance? |
There's a script to automatically update the SASS in mdc_web: https://github.com/jifalops/mdc_web/blob/master/tool/generate_sass.dart. Running that script will install (https://www.npmjs.com/package/material-components-web) version 14.0.0, and attempt to set up the SASS dependencies, but there's a few import issues when I try to run DartPad:
I'm not sure why this mixin isn't available - it probably just needs to be imported. |
It looks like that mixin is deprecated, we'll need to figure out what the upgrade path looks like, but for now I'll try to remove any deprecated mixins and get DartPad building with material-components-web 14.0.0 |
For now, I was able to upgrade dart-sass and sass_builder to the latest version: #2537 |
I played around with
I tried |
I'm going to close this as we aren't going to be using the package anymore, and the underlying web library has been superseded by a new, simplified component library anyway - https://material-web.dev/. |
We currently have to override the
sass
dependency due to a previous issue with Material Components Web which the fix for has not yet rolled intopackage:mdc_web
. Due to changes in modernsass
versions, we also have to restrictsass_builder
to an old version.We should incorporate the new changes into
package:mdc_web
, then update the packages here and remove the necessary overrides.The text was updated successfully, but these errors were encountered: