migrate the analysis config to package:dart_flutter_team_lints #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, interesting - the stable channel has analysis issues; the beta channel doesn't, but fails two tests (though is currently running with |
johnpryan
approved these changes
May 4, 2023
| @@ -54,7 +54,7 @@ serveLocalAppEngine() async { | |||
| _serverUrlOption: 'http://127.0.0.1:8084/', | |||
| }), | |||
| )) | |||
| serveLocalBackend() async { | |||
| Future serveLocalBackend() async { | |||
There was a problem hiding this comment.
Is there a lint rule for avoiding incomplete generic types?
There was a problem hiding this comment.
Possibly? Or perhaps this would be caught by enabling one of:
analyzer:
language:
strict-inference: true
strict-raw-types: true
Co-authored-by: John Ryan <ryjohn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't contain any semantic changes (but does delete some dead code).