Skip to content
This repository has been archived by the owner on Nov 9, 2018. It is now read-only.

Tests failing on latest SDK #40

Open
kevmoo opened this issue Aug 2, 2018 · 3 comments
Open

Tests failing on latest SDK #40

kevmoo opened this issue Aug 2, 2018 · 3 comments

Comments

@kevmoo
Copy link

kevmoo commented Aug 2, 2018

https://travis-ci.org/dart-lang/dart2_fix/builds/410955962

Are things broken on SDKs w/out the old constants, @devoncarew ?

@devoncarew
Copy link
Contributor

Yes, looking at this:

  • we don't try and update code with analysis errors
  • we key off the places in code where the analysis server reports deprecation messages

Removing the deprecated constants from the SDK breaks both of those assumptions. We should update the docs for this tool to state that it can only be run on an sdk after the depreciations were introduced, and before the constants were removed.

@kevmoo
Copy link
Author

kevmoo commented Aug 2, 2018 via email

@devoncarew
Copy link
Contributor

I updated the docs (98f0833), but this is a sticky situation. We either need much longer deprecation periods, or our migration tools should be entirely regex based.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants