Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy approvals from a Gerrit review to its landed commit #48

Closed
whesse opened this issue Dec 2, 2019 · 2 comments
Closed

Copy approvals from a Gerrit review to its landed commit #48

whesse opened this issue Dec 2, 2019 · 2 comments
Projects
Feature Development

Comments

@whesse
Copy link
Contributor

whesse commented Dec 2, 2019

Add logic to use approvals from a CQ run for the CI results that include its landed commit.
@whesse whesse created this issue from a note in Feature Development (To do) Dec 2, 2019
@whesse whesse moved this from To do to In progress in Feature Development Dec 2, 2019
@whesse
Copy link
Contributor Author

whesse commented Dec 2, 2019

Implemented in CL https://dart-review.googlesource.com/c/dart_ci/+/126880

whesse added a commit that referenced this issue Dec 5, 2019
@whesse
[cloud functions] Copy approvals from a Gerrit review when it lands
4b2d033 
Change-Id: I41d88a2cc8d877f70d499561c29c511280f59f87
Bug: #48
Reviewed-on: https://dart-review.googlesource.com/c/dart_ci/+/126880
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
@whesse
Copy link
Contributor Author

whesse commented Jan 24, 2020

Done.

@whesse whesse closed this as completed Jan 24, 2020
Feature Development automation moved this from In progress to Done Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Feature Development
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whesse