Fix accidental reentrance on TopLevelVariables in rare case (#2173)

dart-lang · Apr 9, 2020 · db5fe1c · db5fe1c
1 parent 578400c
commit db5fe1c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/src/model/package_graph.dart b/lib/src/model/package_graph.dart
@@ -105,7 +105,7 @@ class PackageGraph {
           yield d.precacheLocalDocs();
           // TopLevelVariables get their documentation from getters and setters,
           // so should be precached if either has a template.
-          if (m is TopLevelVariable) {
+          if (m is TopLevelVariable && !precachedElements.contains(m)) {
             precachedElements.add(m);
             yield m.precacheLocalDocs();
           }