Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated files and directories may clash with libraries #506

Closed
sethladd opened this issue May 23, 2015 · 5 comments
Closed

Generated files and directories may clash with libraries #506

sethladd opened this issue May 23, 2015 · 5 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@sethladd
Copy link
Contributor

We're putting a css/ directory parallel to generated directories. If a library is named css, it will clash.

Move the resources (css, scripts, etc) away from directories representing the libraries.

@sethladd sethladd added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P1 A high priority bug; for example, a single project is unusable or has many test failures labels May 23, 2015
@sethladd
Copy link
Contributor Author

screen shot 2015-05-23 at 10 34 57 am

@sethladd
Copy link
Contributor Author

We could use a reserved word for the directory that contains css, fonts, etc. That way, the name can't clash with a library name.

here are all the reserved words:

assert, break, case, catch, class, const, continue, default, do, else,
enum, extends, false, final, finally, for, if, in, is, new, null, rethrow,
return, super, switch, this, throw, true, try, var, void, while, with.

This might not be too bad:

const/
  fonts/
  css/
  js/

@sethladd
Copy link
Contributor Author

cc @devoncarew @keertip what do you think?

@sethladd
Copy link
Contributor Author

For now: #513

@sethladd
Copy link
Contributor Author

Man, wouldn't it be cool if static was a reserved word? That would have been perfect for the name of the directory that contains static resources. Alas...

Went with const.

@sethladd sethladd self-assigned this May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

1 participant