Begin abstraction for template render helper #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkoren
force-pushed
the
html_abstraction
branch
from
5ca616d
to
fd5a359
Compare
Adds a class used by TemplateData to help render template elements. Code that produces raw HTML will gradually migrate into this new class.
jdkoren
force-pushed
the
html_abstraction
branch
from
fd5a359
to
45ed4a5
Compare
jcollins-g
approved these changes
Nov 15, 2019
There was a problem hiding this comment.
So I see this as a dependency-injection sort of model? That doesn't seem too bad to me, given that we're kind of adding this on the side as we discussed and I suggested rather than attempting to redo all our templating. So I accept all blame if this goes wrong.... let's see how this goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class used by TemplateData to help render template elements.
Code that produces raw HTML will gradually migrate into this new class.