Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create renderers for more model classes and update some tests #2078

Merged
merged 4 commits into from
Nov 21, 2019
Merged

Create renderers for more model classes and update some tests #2078

merged 4 commits into from
Nov 21, 2019

Conversation

jdkoren
Copy link
Contributor

@jdkoren jdkoren commented Nov 20, 2019

Adds renderer classes for EnumField, Typedef, TypeParameters, and ModelElement.

@googlebot googlebot added the cla: yes Google CLA check succeeded. label Nov 20, 2019
@jdkoren jdkoren marked this pull request as ready for review November 20, 2019 23:56
jcollins-g
jcollins-g approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. As you mention the tests are a little shaky but I think they will be throughout this transition, and I can definitely see improvement in the overall structure.

@jdkoren jdkoren merged commit bd158ec into dart-lang:master Nov 21, 2019
@jcollins-g jcollins-g mentioned this pull request Dec 5, 2019
Closed
@jdkoren jdkoren deleted the renderers branch January 7, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdkoren @jcollins-g @googlebot