Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mustache usage with mustachio #2564

Merged
merged 5 commits into from
Mar 29, 2021
Merged

Replace mustache usage with mustachio #2564

merged 5 commits into from
Mar 29, 2021

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented Mar 9, 2021 •
edited
Loading

I've tested on flutter. Looks great. Small diffs in whitespace.

I've not tested on google3 or on Fuchsia.

I'm trying to make this CL as minimal as possible; an atomic flip. I might be able to tease out a few things here and there to simplify this change.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Mar 9, 2021
jcollins-g
jcollins-g reviewed Mar 9, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flip looks pretty straightforward, excited to see this getting close to landing.

@srawlins srawlins force-pushed the mustachio-c branch 2 times, most recently from 51db7f1 to bcc0076 Compare March 12, 2021 17:54
@coveralls
Copy link

coveralls commented Mar 12, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-32.3%) to 58.962% when pulling 40b44a4 on srawlins:mustachio-c into 8b911bc on dart-lang:master.

@srawlins srawlins force-pushed the mustachio-c branch 3 times, most recently from 3fed8e3 to b7fcb6d Compare March 18, 2021 18:05
@srawlins
Mustachio: fix getter override order, and bounds bug (dart-lang#2523)
a70d66a 
Mustachio: fix getter override order, and bounds bug

Fix indentation in category.html (dart-lang#2521)

WIP: flip to mustachio
@srawlins
Fully replace mustache with mustachio
6c73ec7
@srawlins
Regenerate
060858a
@srawlins
Copy link
Member Author

Okie doke, Imma land this today!

jcollins-g
jcollins-g approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. This will go out on the next release (OK to land now, already landed the release PR), don't quite want to flip this before 0.41.0 as it's kind of enormous. Congrats!!

lib/src/model/typedef.dart Show resolved Hide resolved
@srawlins
Copy link
Member Author

Yesss, excellent. I agree.

@srawlins srawlins merged commit dc93a75 into dart-lang:master Mar 29, 2021
@srawlins srawlins deleted the mustachio-c branch March 29, 2021 19:09
@kevmoo
Copy link
Member

kevmoo commented Mar 29, 2021

@srawlins – could/should you drop the mustache dep in the pubspec?

@srawlins
Copy link
Member Author

Yes I can follow up. I think pub publish gets unhappy about that.

@jcollins-g jcollins-g mentioned this pull request Mar 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srawlins @coveralls @kevmoo @jcollins-g