Remove all dynamic calls and properly enforce lint rule #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcollins-g
approved these changes
Mar 17, 2021
| for (var item in yamlData) { | ||
| returnData.add(item.toString()); | ||
| } | ||
| returnData = [ |
There was a problem hiding this comment.
I think this is fine, though it seems odd to me to omit <String>?
There was a problem hiding this comment.
String is inferred from the elements as the type of the list. This is listed in Effective Dart:
| @@ -1097,7 +1097,7 @@ abstract class ModelElement extends Canonicalization | |||
| } | |||
| if (params == null && element is FunctionTypedElement) { | |||
| if (_originalMember != null) { | |||
| params = (_originalMember as dynamic).parameters; | |||
There was a problem hiding this comment.
this is a good one to get rid of. That might cover up some nasty bugs otherwise. Don't remember why that is there...
There was a problem hiding this comment.
Haha it was a little weird.
| String name = decodedJson['name']; | ||
| var versions = List<Version>.from( | ||
| decodedJson['versions'].map((v) => Version.parse(v))); | ||
| var versions = [ |
There was a problem hiding this comment.
Assuming inference works properly for the list type here?
There was a problem hiding this comment.
Right, Version.parse returns a Version, and this is the only element (repeated) in the list, so inference will find Version.
jcollins-g
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.