Enhance browser search experience #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this will ship in the next dartdoc publish, which I plan to do next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary cause of the unpleasant browser search experience was the order in which sidebars were placed in the DOM, which would make results from the left sidebar to precede those from the main content while using any browser's search functionality.
It is fixed by reordering the sidebars in the DOM while preserving the visual order using flex order as suggested by @mleonhard in #2131 (comment).
As a bonus this also fixes an a11y issue where screen readers would first read out contents of the sidebar instead of the main content as they also rely on the DOM order.
Related Issues:
Fixes #2131
Fixes flutter/flutter#80849