Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a README for mustachio. #2623

Merged
merged 4 commits into from Apr 28, 2021
Merged

Introduce a README for mustachio. #2623

merged 4 commits into from Apr 28, 2021

Conversation

srawlins
Copy link
Member

I had to choose between lib/src/mustachio/ and tool/mustachio and decided to put the README in the latter, and put references to it in the former, since the latter directory has the actual generators.

Just a start, but I have most of the rest of the content sitting in a Google doc, so you might have faith that I will finish writing it 馃榿 .

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Apr 23, 2021
jcollins-g
jcollins-g approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad to have the documentation here.

@coveralls
Copy link

coveralls commented Apr 27, 2021 •
edited

Coverage Status

Coverage remained the same at 57.473% when pulling 878a64e on srawlins:mustachio-readme into f9a875d on dart-lang:master.

parlough
parlough approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@parlough parlough left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great introduction from both a dartdoc user and dartdoc developer perspective, amazing job.

I would personally say landing this as is would be worth it and other improvements and missing pieces could follow :)

@srawlins srawlins merged commit 55034c5 into dart-lang:master Apr 28, 2021
@srawlins srawlins deleted the mustachio-readme branch April 28, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srawlins @coveralls @jcollins-g @parlough