Write basic parser for comment references #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
May 5, 2021
| if (prefixResult.type == _PrefixResultType.parsedConstructorHint) { | ||
| children.add(prefixResult.node); | ||
| } | ||
| // junk / missing we can skip. |
There was a problem hiding this comment.
I wasn't sure what this comment is referring to, until I read further. Maybe call out _PrefixResultType.junk and _PrefixResultType.missing explicitly.
| return; | ||
| } | ||
|
|
||
| /// Returns true if we started with startChar and ended with endChar |
There was a problem hiding this comment.
can reference startChar as [startChar] and endChar with [endChar] :D
|
|
||
| /// Returns true if we started with startChar and ended with endChar | ||
| /// with a matching number of braces. | ||
| /// Returns _index to start if returning false. |
There was a problem hiding this comment.
"startIndex" would be more meaningful than "start" here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to replace the string splits/joins and regular expressions scattered throughout markdown_processor.dart in the new lookup system.