Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with location calculation in enum fields #2660

Merged
merged 4 commits into from May 26, 2021
Merged

Fix problem with location calculation in enum fields #2660

merged 4 commits into from May 26, 2021

Conversation

jcollins-g
Copy link
Contributor

Fixes #2659.

This will also avoid the assert in angular.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label May 26, 2021
@jcollins-g jcollins-g requested a review from srawlins May 26, 2021 20:46
@coveralls
Copy link

coveralls commented May 26, 2021 •
edited

Coverage Status

Coverage decreased (-0.3%) to 57.943% when pulling b4a088e on jcollins-g:character-location-enums into 18e648a on dart-lang:master.

@jcollins-g jcollins-g merged commit 9d89c34 into dart-lang:master May 26, 2021
@jcollins-g jcollins-g mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

characterLocation of Enum implicit accessors is invalid
3 participants
@jcollins-g @coveralls @srawlins