Add end-to-end tests for Mustachio AOT compiler #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests, in aot_compiler_render_test.dart, are a little irregular. The goal is to write short test cases in which we specify the text of a Mustache template, and the expected rendered text, visually near each other, which is a challenge, as there are several steps to get from Mustache template text to rendered output, including running the builders, and executing freshly generated Dart code. The solution here is a test system which takes a Mustache template text, runs the mustachio AOT compiler to generate a Dart script which renders a context object into that template, then executes the generated Dart script, and asserts on the output. Writing these tests revealed a few bugs that are fixed concurrently: * imports in the generated script should be accurate; this requires using code_builder, which requires a sizeable change to the AOT compiler code. code_builder allows you to "reference" symbols like types or top-level functions and the URL where they may be found. * handle partial template paths with dots and slashes. Additionally, fix some nits in runtime_renderer_builder_test.dart and runtime_renderer_render_test.dart.
jcollins-g
approved these changes
Jun 2, 2021
|
https://github.com/dart-lang/dartdoc/pull/2664/checks?check_run_id=2737504814#step:7:3992 Looks like we need to use pkg:path! |
kevmoo
reviewed
Jun 3, 2021
| @@ -18,6 +16,10 @@ void main() { | |||
| var dartdocLibUri = await Isolate.resolvePackageUri( | |||
| Uri.parse('package:dartdoc/dartdoc.dart')); | |||
| var dartdocPath = p.dirname(p.dirname(dartdocLibUri.path)); | |||
| // Correct Windows issue path coming out of [Isolate.resolvePackageUri]. | |||
| if (dartdocPath.startsWith(p.windows.separator)) { | |||
| dartdocPath = dartdocPath.substring(1).replaceAll('/', p.separator); | |||
There was a problem hiding this comment.
so weird that pkg:path doesn't "do the right thing" here!
There was a problem hiding this comment.
Yeah it is curious. I think the issue is that Isolate.resolvePackageUri gives a Uri like file:///C:/one/two, which maybe isn't incorrect because URIs should always have /, even on Windows? And then I ask for the .path out of that, which gives /C:/one/two and now we're in trouble.
|
I'm landing this before it breaks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests, in aot_compiler_render_test.dart, are a little irregular. The goal
is to write short test cases in which we specify the text of a Mustache
template, and the expected rendered text, visually near each other, which is a
challenge, as there are several steps to get from Mustache template text to
rendered output, including running the builders, and executing freshly
generated Dart code.
The solution here is a test system which takes a Mustache template text, runs
the mustachio AOT compiler to generate a Dart script which renders a context
object into that template, then executes the generated Dart script, and
asserts on the output.
Writing these tests revealed a few bugs that are fixed concurrently:
code_builder, which requires a sizeable change to the AOT compiler code.
code_builder allows you to "reference" symbols like types or top-level
functions and the URL where they may be found.
Additionally, fix some nits in runtime_renderer_builder_test.dart and
runtime_renderer_render_test.dart.