Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about a failed snapshot #2689

Closed
wants to merge 0 commits into from
Closed

Warn about a failed snapshot #2689

wants to merge 0 commits into from

Conversation

srawlins
Copy link
Member

DRAFT

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Jun 18, 2021
@srawlins
Copy link
Member Author

@jcollins-g This PR presently has a big bug that I cannot figure out: if the snapshot indeed fails, then as soon as it does, my computer is immediately spammed with dozens of dart processes running snippet/main.dart. It slows to a deathly crawl if I don't kill dartdoc quickly.

Can you tell just by looking at the small change why on earth it would totally unwrap the pooling feature in ToolTracker?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 58.091% when pulling c7b4321 on srawlins:warn-snapshot into 3cf7c63 on dart-lang:master.

@jcollins-g
Copy link
Contributor

@srawlins maybe this can be revived since #2730?

@srawlins srawlins closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srawlins @coveralls @jcollins-g