Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up Class class, which is not a supertype of Enum class #3727

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

srawlins
Copy link
Member

In #3697 I had made Enum a subclass of Class, but it turned out to be a step in the wrong direction. I backed out part of that change, but I missed some things. This simplifies Class back to it's much simpler state.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from kallentu March 18, 2024 22:24
@srawlins srawlins merged commit 1f06752 into dart-lang:main Mar 18, 2024
9 checks passed
@srawlins srawlins deleted the little-things-3 branch March 18, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants