Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support github deployment environments #130

Closed
jakemac53 opened this issue Jul 6, 2023 · 1 comment · Fixed by #131
Closed

Support github deployment environments #130

jakemac53 opened this issue Jul 6, 2023 · 1 comment · Fixed by #131
Labels
package:firehose

Comments

@jakemac53
Copy link
Contributor

See https://dart.dev/tools/pub/automated-publishing#hardening-security-with-github-deployment-environments.

I think this is just adding another input to the rule and forwarding that through to the setup-dart action.
@jakemac53
Copy link
Contributor Author

Note that it would be nice if this could only require the given environment for publishing, and not for validation on PRs. I think that would require splitting them into separate jobs.

@jakemac53 jakemac53 mentioned this issue Jul 6, 2023
Merged
jakemac53 added a commit that referenced this issue Jul 10, 2023
@jakemac53
add environment input to support github deployment environments (#131)
5a9f06b 
Closes #130

Separates publish/validate into two different jobs. The publish job will use the supplied environment, which may require approvals to run the jobs if configured. See https://dart.dev/tools/pub/automated-publishing#hardening-security-with-github-deployment-environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:firehose
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add environment input to support github deployment environments dart-lang/ecosystem
1 participant
@jakemac53