Small changes #11
Merged
Small changes #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Nov 9, 2022
| buf.writeln('https://api.dart.dev/dart-${reportTarget.name}/' | ||
| 'dart-${reportTarget.name}-library.html'); | ||
| } else { | ||
| buf.writeln(reportTarget.description); | ||
| buf.writeln((reportTarget as PackageTarget).description); |
There was a problem hiding this comment.
If description were a nullable property of ReportTarget we could avoid this cast.
There was a problem hiding this comment.
Added the type check to clarify, but I would rather not make this a property of ReportTarget as a DartLibraryTarget really has no description (so far).
devoncarew
added a commit
that referenced
this pull request
Nov 10, 2022
* add support for dart: libraries * commit two sample reports * Small changes (#11) * Small changes * Rename class * Inline variable Co-authored-by: Moritz <mosum@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I also like composition over inheritance, I thought this would be a good use of polymorphism. This is absolutely optional, just an idea.