Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty coverage #128

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Allow empty coverage #128

merged 2 commits into from
Jul 10, 2023

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jul 4, 2023

Fix a bug where empty coverage leads to workflow failure.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from kevmoo July 4, 2023 22:08
@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.3.21 ready to publish firehose-v0.3.21
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

PR Health

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.3.21 ready to publish
package:dart_flutter_team_lints 1.0.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

License Headers ✔️

Details
// Copyright (c) 2023, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

@mosuem mosuem merged commit b34db4f into main Jul 10, 2023
17 checks passed
@mosuem mosuem deleted the allowEmptyCoverage branch July 10, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants