Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmetic update to the triager's comment format #273

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

devoncarew
Copy link
Member

  • cosmetic update to the triager's comment format

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

This changes the comment from:

dart-lang/sdk#56051 (comment)

to:

Summary: The covariant_instance_field_test fails when inlining is disabled, causing a runtime error where a late covariant field is assigned a value of the wrong type. This issue may be related to the experimental linker changes made to Shorebird.

@devoncarew devoncarew requested a review from mosuem June 19, 2024 18:41
@devoncarew devoncarew enabled auto-merge (squash) June 19, 2024 18:41
Copy link

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:dart_flutter_team_lints 3.1.0 already published at pub.dev
package:firehose 0.9.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@devoncarew devoncarew merged commit 31148cd into main Jun 20, 2024
27 checks passed
@devoncarew devoncarew deleted the update_triager_comment branch June 20, 2024 07:27
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 20, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/818d1f5..6330a13):
  6330a13e  2024-06-18  Sam Rawlins  Declare local variables for the 'href' field, to promote and avoid printing 'null' (dart-lang/dartdoc#3788)
  822ca007  2024-06-18  Sam Rawlins  Stop supporting '[this]' as a comment reference. (dart-lang/dartdoc#3765)

ecosystem (https://github.com/dart-lang/ecosystem/compare/8ada2ee..31148cd):
  31148cd  2024-06-20  Devon Carew  cosmetic update to the triager's comment format (dart-lang/ecosystem#273)

glob (https://github.com/dart-lang/glob/compare/eaec6a4..6d3ba5e):
  6d3ba5e  2024-06-20  Kevin Moore  update lints (dart-lang/glob#95)

logging (https://github.com/dart-lang/logging/compare/dbd6829..240ec33):
  240ec33  2024-06-20  Kevin Moore  Update lints dep, bump min SDK (dart-lang/logging#167)

Change-Id: I2a691c3a4d02f55a625afaa855ab3e5aa60259c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/372520
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants