Handle unpublishable packages missing a version #60
Conversation
Fix string quote for missing environment var
| @@ -92,6 +92,15 @@ See also the docs at https://github.com/dart-lang/ecosystem/wiki/Publishing-auto | |||
|
|
|||
| print('pubspec:'); | |||
| var pubspecVersion = package.pubspec.version; | |||
| if (pubspecVersion == null) { | |||
There was a problem hiding this comment.
It makes sense to handle the NPE here, but the we're also assuming that the target repo should mark that package as publish_to: none, right?
There was a problem hiding this comment.
Maybe? We should decide and either error w/ a good message – or warn maybe?
publish_to: none and/or no version – right?
There was a problem hiding this comment.
The convention this tool is using is to reply on publish_to: none; I'd prefer to use that consistently as the 'not intended for publishing signal'.
In previous iterations of the tool I'd had an explicit opt-in signal (auto-publish: true) and used publish_to: none as a negative signal, but it ended up being more complicated than it was worth - users not exactly knowing which packages would be managed by the publishing automation.
Fix string quote for missing environment var