Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off scheduled_test #15

Merged
merged 4 commits into from
Sep 15, 2017
Merged

Migrate off scheduled_test #15

merged 4 commits into from
Sep 15, 2017

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Sep 15, 2017

No description provided.

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the version bump

@@ -1,15 +1,15 @@
name: glob
version: 1.1.4
version: 1.1.5-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there actually a breaking change? I didn't see one...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Hence just a minor bump. Since we update the SDK constraint...also pre-release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sheesh sorry I read that as a breaking change for some dumb reason, LGTM

@kevmoo kevmoo merged commit 8c8ce45 into master Sep 15, 2017
@kevmoo kevmoo deleted the i14_no_scheduled_test branch September 15, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants