Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacOS.prefer_64_bit is deprecated. #58

Closed
voldemortensen opened this issue Jan 8, 2019 · 8 comments
Closed

MacOS.prefer_64_bit is deprecated. #58

voldemortensen opened this issue Jan 8, 2019 · 8 comments
Assignees
@kevmoo

Comments

@voldemortensen
Copy link

While upgrading dart I received this error:
Error: dart-lang/dart/dart: undefined method prefer_64_bit?' for OS::Mac:Module`

Upon further investigation I found that the prefer_64_bit method has been deprecated. See Homebrew/brew@170c549#diff-1c1e64ec9fa3342388d0ddb7a9607eca

The new way to check is the is_64_bit method.
@kevmoo
Copy link
Member

kevmoo commented Jan 8, 2019

CC @whesse @athomas – should be an easy fix

@puxlit
Copy link

puxlit commented Jan 9, 2019

@voldemortensen, shouldn't that be Hardware::CPU.is_64_bit? instead of MacOS.is_64_bit??

@voldemortensen
Copy link
Author

voldemortensen commented Jan 9, 2019 via email

@r6m
Copy link

r6m commented Jan 9, 2019

Hi, it still gives the error. Isn't it fixed yet?

@am11 am11 mentioned this issue Jan 9, 2019
Closed
@AlexGHancock
Copy link

Same problem here... Perhaps I should downgrade homebrew to get it working?

itzsaga pushed a commit to itzsaga/homebrew-dart that referenced this issue Jan 9, 2019
Fixes dart-lang#58
67ad17f
@outlandnish outlandnish mentioned this issue Jan 9, 2019
Closed
@kevmoo kevmoo closed this as completed in b371044 Jan 9, 2019
@kevmoo
Copy link
Member

kevmoo commented Jan 9, 2019

This is not completely fix yet – Need to update https://github.com/dart-lang/sdk/tree/master/tools/apps/update_homebrew too!

@kevmoo kevmoo reopened this Jan 9, 2019
@kevmoo kevmoo self-assigned this Jan 9, 2019
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jan 10, 2019
@kevmoo
update_homebrew: initial cleanup
d908743 
Before fixing dart-lang/homebrew-dart#58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
dart-bot pushed a commit to dart-lang/sdk that referenced this issue Jan 10, 2019
@kevmoo
Generate homebrew script compatible with latest changes
8719fb3 
Fixes dart-lang/homebrew-dart#58

Change-Id: I23e38db5448c5d8ceb55d57689eda0eecf80c630
Reviewed-on: https://dart-review.googlesource.com/c/88883
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
@kevmoo
Copy link
Member

kevmoo commented Jan 10, 2019

Fixed in dart-lang/sdk@8719fb3

@kevmoo kevmoo closed this as completed Jan 10, 2019
@voldemortensen
Copy link
Author

Thanks for the fix!

@toyoxx toyoxx mentioned this issue Feb 6, 2019
Open
@bardiharborow bardiharborow mentioned this issue Feb 26, 2019
Merged
@HenryQW HenryQW mentioned this issue Jun 9, 2019
Merged
kcking pushed a commit to kryptco/homebrew-tap that referenced this issue Jun 10, 2019
@HenryQW @kcking
fix: prefer_64_bit is deprecated
0dee0c5 
See Homebrew/brew@170c549#diff-1c1e64ec9fa3342388d0ddb7a9607eca and dart-lang/homebrew-dart#58
@passsy passsy mentioned this issue Aug 19, 2020
Merged
athomas pushed a commit that referenced this issue Jun 4, 2021
@kevmoo @athomas
update_homebrew: initial cleanup
4f888ab 
Before fixing #58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
athomas pushed a commit that referenced this issue Jun 4, 2021
@kevmoo @athomas
Generate homebrew script compatible with latest changes
cbf9e48 
Fixes #58

Change-Id: I23e38db5448c5d8ceb55d57689eda0eecf80c630
Reviewed-on: https://dart-review.googlesource.com/c/88883
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
athomas pushed a commit that referenced this issue Jul 1, 2021
@kevmoo @athomas
update_homebrew: initial cleanup
c93614e 
Before fixing #58

Change-Id: Id09065c9a732d0eb4268f2667ff1bfea635d0922
Reviewed-on: https://dart-review.googlesource.com/c/88900
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
athomas pushed a commit that referenced this issue Jul 1, 2021
@kevmoo @athomas
Generate homebrew script compatible with latest changes
8f2f314 
Fixes #58

Change-Id: I23e38db5448c5d8ceb55d57689eda0eecf80c630
Reviewed-on: https://dart-review.googlesource.com/c/88883
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevmoo kevmoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @puxlit @voldemortensen @r6m @AlexGHancock