Ignore duplicate spans when parsing

Fixes #56
dart-lang · Jan 9, 2018 · f061a0e · f061a0e
1 parent 82bea83
commit f061a0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/dom.dart b/lib/dom.dart
@@ -284,6 +284,10 @@ abstract class Node {
         generateSpans: true, attributeSpans: true);
 
     tokenizer.moveNext();
+
+    while (tokenizer.current is ParseErrorToken) {
+      tokenizer.moveNext();
+    }
     var token = tokenizer.current as StartTagToken;
 
     if (token.attributeSpans == null) return; // no attributes

diff --git a/test/parser_test.dart b/test/parser_test.dart
@@ -9,6 +9,7 @@ import 'package:html/dom.dart';
 import 'package:html/parser.dart';
 import 'package:html/parser_console.dart' as parser_console;
 import 'package:html/src/inputstream.dart' as inputstream;
+import 'package:source_span/source_span.dart';
 import 'support.dart';
 
 // Run the parse error checks
@@ -71,6 +72,12 @@ void runParserTest(
 }
 
 void main() {
+  test('ignore duplicate attributes when parsing', () {
+    var dom = parse('<div duplicate duplicate>', generateSpans: true);
+    expect(dom.querySelector('div').attributeSpans,
+        {'duplicate': new isInstanceOf<FileSpan>()});
+  });
+
   test('dart:io', () {
     // ensure IO support is unregistered
     expect(inputstream.consoleSupport,