Migrate to null safety #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Append `-nullsafety` to version. - Set min SDK to `2.11.0-0`, add `publish_to:none` since this package is not in the allow list. - Use late field initialization over constructor assignment to clean up the handling of backreferences in the different "phases". - Remove some conditional branches that are impossible to hit.
lrhn
reviewed
Oct 19, 2020
- Make Text.data consistently non nullable for getter and setter. - Add a local variable to avoid double null check for a field. - Make the `container` argument non-nullable in multiple places. - Remove unused `container` field. - Use `?.` over null check then `!`.
|
@lhrn can you check out my responses to your earlier comments? |
|
Will this PR be landed? We transitively use |
|
I'll revisit this PR. I think it's currently waiting for me to respond to Lasse's most recent comments. |
|
Ok, I think the last change needed was the switch to use |
jakemac53
reviewed
Jan 25, 2021
jakemac53
reviewed
Jan 25, 2021
| @@ -156,28 +157,26 @@ abstract class Node { | |||
|
|
|||
| /// A list of child nodes of the current node. This must | |||
| /// include all elements but not necessarily other node types. | |||
| final NodeList nodes = NodeList._(); | |||
| late final nodes = NodeList._(this); | |||
There was a problem hiding this comment.
Do we want to avoid exposing the setter here?
There was a problem hiding this comment.
This has an initializing expression, so ti doesn't expose the setter.
jakemac53
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-nullsafetyto version.2.11.0-0, addpublish_to:nonesince this package isnot in the allow list.
the handling of backreferences in the different "phases".