Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs, there are no constructor http.MultipartFile.fromFile #140

Closed
dnp1 opened this issue Nov 21, 2017 · 2 comments
Closed

Update docs, there are no constructor http.MultipartFile.fromFile #140

dnp1 opened this issue Nov 21, 2017 · 2 comments

Comments

@dnp1
Copy link

dnp1 commented Nov 21, 2017

The constructor http.MultipartFile.fromFile is mentioned here: https://www.dartdocs.org/documentation/http/0.11.3%2B16/http/MultipartRequest-class.html

But it doesn't exists

@nex3
Copy link
Member

nex3 commented Nov 21, 2017

The erroneous documentation has already been removed on master, so I'm going to close this.

@nex3 nex3 closed this as completed Nov 21, 2017
@genesiscz
Copy link

genesiscz commented Feb 10, 2019

There's a minor mistake in the example on that page,

var uri = Uri.parse("http://pub.dartlang.org/packages/create"); // uri
var request = new http.MultipartRequest("POST", url); // url

Also I see fromFile is still sitting there on the page but no fromFile method exists. This issue is NOT FIXED

@natebosch natebosch reopened this Mar 6, 2019
natebosch added a commit that referenced this issue Mar 6, 2019
Fixes #140

- `MultipartFile.fromFile` does not exist, update to `fromPath`.
- Use async/await.
- Use single quotes consistently.
natebosch added a commit that referenced this issue Mar 6, 2019
Fixes #140

- `MultipartFile.fromFile` does not exist, update to `fromPath`.
- Use async/await.
- Use single quotes consistently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants