Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of multiple CupertinoClients can result in cancelled requests #826

Closed
brianquinlan opened this issue Nov 17, 2022 · 0 comments · Fixed by #827
Closed

Use of multiple CupertinoClients can result in cancelled requests #826

brianquinlan opened this issue Nov 17, 2022 · 0 comments · Fixed by #827
Assignees
@brianquinlan
Labels
package:cupertino_http Issues related to package:cupertino_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@brianquinlan
Copy link
Collaborator

The reason is that CupertinoClient._tasks uses taskIdentifier as a key, which is not guaranteed to be unique across NSURLSession instances.
@brianquinlan brianquinlan added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) package:cupertino_http Issues related to package:cupertino_http labels Nov 17, 2022
@brianquinlan brianquinlan self-assigned this Nov 17, 2022
brianquinlan added a commit to brianquinlan/http that referenced this issue Nov 18, 2022
@brianquinlan
Fixes a bug where simultaneous requests made in different Clients wou…
9237f13 
…ld fail

Fixes dart-lang#826
@brianquinlan brianquinlan mentioned this issue Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
package:cupertino_http Issues related to package:cupertino_http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a bug where requests made in different Clients would fail brianquinlan/http
1 participant
@brianquinlan