Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Window Update size #124

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Increase Window Update size #124

wants to merge 5 commits into from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Jun 6, 2023

Instead of sending small window updates, the same size as the DATA length received, send larger updates once a certain portion of the window has been used up, as suggested here.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Jun 12, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
http2 None 2.3.1-wip 2.3.1-wip 2.3.1-wip ✔️

Changelog Entry ❗

Details
Package Changed Files
package:http2 lib/http2.dart
lib/src/flowcontrol/window.dart
lib/src/flowcontrol/window_handler.dart
lib/src/frames/frames.dart
lib/src/hpack/hpack.dart
pubspec.yaml

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️

Details
File Coverage
lib/http2.dart 💔 Not covered
lib/src/flowcontrol/window.dart 💚 100 %
lib/src/flowcontrol/window_handler.dart 💚 100 %
lib/src/frames/frames.dart 💔 Not covered
lib/src/hpack/hpack.dart 💚 96 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
test/src/flowcontrol/mocks.mocks.dart

Package publish validation ✔️

Details
Package Version Status
package:http2 2.3.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant