Fix flakiness in detection of notDisposed leaks in tests. #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
polina-c
changed the title
8 tasks
bkonyi
approved these changes
Sep 28, 2023
| void declareAllNotDisposedAsLeaks() { | ||
| throwIfDisposed(); | ||
| final notGCedAndNotDisposed = <ObjectRecord>[]; | ||
| _objects.notGCed.forEach((record) { |
There was a problem hiding this comment.
Nit: lots of projects have lints recommending that we don't use forEach. Even if we don't have it enabled for this project, consider doing this instead:
for (final record in _objects.notGCed) {
if (!record.isDisposed) {
_declareNotDisposedLeak(record);
}
}There was a problem hiding this comment.
The lint is enabled for this project. notGCed is not iterable though. I will check if it is easy to make it iterable.
There was a problem hiding this comment.
Oh interesting. At the very least, I don't think you need noGCedAndNotDisposed, but you could instead do:
_objects.notGCed.forEach((record) {
if (!record.isDisposed) {
_declareNotDisposedLeak(record);
}
});There was a problem hiding this comment.
Yes, looks as optimizable. Added comment why I did it:
// We need this temporary storage to avoid errror 'concurrent modification during iteration'
// for internal iterables in `_objects.notGCed`.
There was a problem hiding this comment.
And I checked: Iterable wants 27 methods to be implemented. Seems to be too heavy.
This was referenced Sep 28, 2023
CoderDake
approved these changes
Sep 29, 2023
Co-authored-by: Daniel Chevalier <danchevalier@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to flutter/flutter#135716
This is follow up to fix leak tracker flakiness: flutter/flutter#135394
This PR resolves false negatives, so it is breaking change.
Objects, not disposed by the end of the test, should be marked as leaks, even if they are not GCed yet.
The upgrade to this version should be handled manually, because it may result in some tests failing.