Skip to content

Commit

Permalink
Remove duplication in visitTypeName.
Browse files Browse the repository at this point in the history
  • Loading branch information
pq committed Aug 2, 2017
1 parent ab5d4ec commit 8c326f7
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions lib/src/rules/always_specify_types.dart
Expand Up @@ -126,6 +126,7 @@ class Visitor extends SimpleAstVisitor {
checkLiteral(literal);
}

// Future kernel API.
visitNamedType(NamedType namedType) {
DartType type = namedType.type;
if (type is ParameterizedType) {
Expand All @@ -152,15 +153,7 @@ class Visitor extends SimpleAstVisitor {

@override
visitTypeName(NamedType typeName) {
DartType type = typeName.type;
if (type is ParameterizedType) {
if (type.typeParameters.isNotEmpty &&
typeName.typeArguments == null &&
typeName.parent is! IsExpression &&
!_isOptionallyParameterized(type)) {
rule.reportLint(typeName);
}
}
visitNamedType(typeName);
}

@override
Expand Down

0 comments on commit 8c326f7

Please sign in to comment.