Fix failure when linting getters (issue 27545)

R=pquitslund@google.com Review URL: https://codereview.chromium.org//2403443003 .
dart-lang · Oct 7, 2016 · aca9843 · aca9843
1 parent 4239523
commit aca9843
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 6 deletions.
diff --git a/lib/src/rules/parameter_assignments.dart b/lib/src/rules/parameter_assignments.dart
@@ -78,10 +78,14 @@ class _Visitor extends SimpleAstVisitor {
 
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
-    node.parameters.parameters.forEach((e) {
-      if (node.body.isPotentiallyMutatedInScope(e.element)) {
-        rule.reportLint(e);
-      }
-    });
+    FormalParameterList parameterList = node.parameters;
+    if (parameterList != null) {
+      // Getters don't have parameters.
+      parameterList.parameters.forEach((e) {
+        if (node.body.isPotentiallyMutatedInScope(e.element)) {
+          rule.reportLint(e);
+        }
+      });
+    }
   }
 }
diff --git a/test/rules/parameter_assignments.dart b/test/rules/parameter_assignments.dart
@@ -13,7 +13,13 @@ void ok(String parameter) {
 }
 
 class A {
-    void badFunction(int parameter) { // LINT
+  int get x => 0;
+
+  set x(int value) { // LINT
+    value = 5;
+  }
+
+  void badFunction(int parameter) { // LINT
     parameter = 4;
   }