Fix comment_references in the face of incomplete references (#819)

Fixes: #819
dart-lang · Oct 24, 2017 · b4442ee · b4442ee
1 parent d564693
commit b4442ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/src/rules/comment_references.dart b/lib/src/rules/comment_references.dart
@@ -68,7 +68,7 @@ class Visitor extends SimpleAstVisitor {
                   rule.lintCode, nameOffset, reference.length);
             }
           }
-          leftIndex = comment.indexOf('[', rightIndex);
+          leftIndex = rightIndex < 0 ? -1 : comment.indexOf('[', rightIndex);
         }
       }
     }

diff --git a/test/rules/comment_references.dart b/test/rules/comment_references.dart
@@ -24,3 +24,9 @@ class A {
   /// Writes [y]. #LINT
   void write(int x) {}
 }
+
+/// [
+/// ^--- Should not crash (#819).
+class B {
+
+}