Allow += in prefer_interpolation_to_compose_strings (#813). (#831)

Fixes: #813
dart-lang · Nov 1, 2017 · caf2e34 · caf2e34
1 parent cd13719
commit caf2e34
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/lib/src/rules/prefer_interpolation_to_compose_strings.dart b/lib/src/rules/prefer_interpolation_to_compose_strings.dart
@@ -47,21 +47,6 @@ class _Visitor extends SimpleAstVisitor {
 
   _Visitor(this.rule);
 
-  @override
-  visitAssignmentExpression(AssignmentExpression node) {
-    if (skippedNodes.contains(node)) {
-      return;
-    }
-    if (node.operator.type == TokenType.PLUS_EQ &&
-        (DartTypeUtilities.isClass(
-                node.leftHandSide.bestType, 'String', 'dart.core') ||
-            DartTypeUtilities.isClass(
-                node.rightHandSide.bestType, 'String', 'dart.core'))) {
-      DartTypeUtilities.traverseNodesInDFS(node).forEach(skippedNodes.add);
-      rule.reportLint(node);
-    }
-  }
-
   @override
   visitBinaryExpression(BinaryExpression node) {
     if (skippedNodes.contains(node)) {

diff --git a/test/rules/prefer_interpolation_to_compose_strings.dart b/test/rules/prefer_interpolation_to_compose_strings.dart
@@ -14,7 +14,7 @@ void main() {
       '! You are ' +
       (year - birth).toString() +
       ' years old.';
-  name += 'casanueva'; // LINT
+  name += 'casanueva'; // OK (#813)
 
   int width = 10;
   String pad = '';