prefer_interpolation_to_compose_strings should apply only for String.+ (

#2667)
dart-lang · May 21, 2021 · ce5c72d · ce5c72d
1 parent fbbd359
commit ce5c72d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/src/rules/prefer_interpolation_to_compose_strings.dart b/lib/src/rules/prefer_interpolation_to_compose_strings.dart
@@ -75,8 +75,7 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (leftOperand is StringLiteral && rightOperand is StringLiteral) {
         return;
       }
-      if ((leftOperand.staticType?.isDartCoreString ?? false) ||
-          (rightOperand.staticType?.isDartCoreString ?? false)) {
+      if (leftOperand.staticType?.isDartCoreString ?? false) {
         DartTypeUtilities.traverseNodesInDFS(node).forEach(skippedNodes.add);
         rule.reportLint(node);
       }

diff --git a/test_data/rules/prefer_interpolation_to_compose_strings.dart b/test_data/rules/prefer_interpolation_to_compose_strings.dart
@@ -31,3 +31,10 @@ issue2490() {
   final String foo = 'Hello';
   final String bar = foo + r' /world\'; // OK
 }
+
+class Issue792 {
+  Issue792 operator +(String other) => this;
+  f() {
+    var a = this + ' '; // OK
+  }
+}