dartdoc and comment_references lint disagree on [true] and [false]

[pq]

From @kevmoo on October 18, 2017 1:51

If one enables the comment_references lint, doing[true] or [false] is fine.

dartdoc reports these as unresolved-doc-reference

...should be consistent

Copied from original issue: dart-lang/dartdoc#1519

[pq]

From @kevmoo on October 18, 2017 1:56

FYI @pq

[pq]

From @jcollins-g on October 18, 2017 15:13

dartdoc does not currently support keywords in comment references, but this could be added.

[pq]

From @devoncarew on October 18, 2017 15:23

We may want to choose to change the lint here. I'd expect the contents of square brackets to generally be something that resolves to a symbol. For this case, the user should probably write:

`true`

[pq]

From @jcollins-g on October 18, 2017 15:35

I can also see the argument for [] working for true or false, since functionally those work the same as final global bools and when I'm coding, I don't usually make the distinction in my head that these are keywords.

In general, better synchronization between the linter and dartdoc seems like a good idea if we can find the space for it.

[pq]

From @kevmoo on October 18, 2017 15:54

It's not like true exists as a top-level field in dart:core, though.
There is nothing for dartdoc to link to.

I'd rather we change linter, IMHO

On Wed, Oct 18, 2017 at 8:35 AM, jcollins-g notifications@github.com
wrote:

I can also see the argument for [] working for true or false, since
functionally those work the same as final global bools and when I'm coding,
I don't usually make the distinction in my head that these are keywords.

In general, better synchronization between the linter and dartdoc seems
like a good idea if we can find the space for it.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
dart-lang/dartdoc#1519 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCikHZSLH9dkc_4_N2i9PfKSxRX5C6ks5sthrNgaJpZM4P9DKP
.