Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ no_leading_underscores_for_{library_prefixes, local_identifiers} #3062

Merged
merged 10 commits into from Nov 16, 2021

Conversation

pq
Copy link
Member

@pq pq commented Nov 15, 2021

See: #1750.

Fixes #1676.

/cc @bwilkerson

/fyi @jawahars16 @srawlins

@google-cla google-cla bot added the cla: yes label Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021

Coverage Status

Coverage increased (+0.03%) to 94.167% when pulling 35ee68e on no_leading_underscores_for_local_identifiers into 0537764 on master.

@pq pq changed the title + no_leading_underscores_for_local_identifiers + no_leading_underscores_for_{library_prefixes, local_identifiers} Nov 15, 2021
@pq pq merged commit bdf8546 into master Nov 16, 2021
@pq pq deleted the no_leading_underscores_for_local_identifiers branch November 16, 2021 18:39
mockturtl added a commit to mockturtl/tidy that referenced this pull request Nov 24, 2021
- `no_leading_underscores_for_library_prefixes` dart-lang/linter#3062
- `no_leading_underscores_for_local_identifiers` dart-lang/linter#3062
- `secure_pubspec_urls` dart-lang/linter#3056
- `use_decorated_box` dart-lang/linter#3061
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
…art-lang/linter#3062)

* + no_leading_underscores_for_local_identifiers

* + no_leading_underscores_for_library_prefixes

* comment re-parent

* newline

* smith

* msg tweak

* re-sort

* + tests; doc

* forparts

* test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule for using a leading underscore for identifiers that aren't private
3 participants