Introduce a set of "canonical" lints for Google projects #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #7, #251 (comment) |
|
Just an update. We are closing this and re-opening under another package. |
|
Can you please provide link to the new issue? |
|
This was replaced internally there is no new issue right now. On Sat, Nov 12, 2016, 8:55 PM Alexei Eleusis Diaz Vera <
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on internal discussions of what we enforce as part of the Google style guide, and what we would suggest going forward for all new Dart projects, specifically those created and owned by the Dart team (i.e. in
dart-lang/*).Please comment if you have suggestions about:
google.md(make it more clear, etc)If you disagree about this sets of lints, please contact me internally if you are a Dart team member or a Google employee - this is currently the set of lints we enforce internally + some additions that will be rolled out soon.
Community contributors, feel free to start a discussion if you feel strongly about something.
Awaiting LGTM from:
/cc @yjbanov