Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a simple override to make a @protected method public #3482

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Allow a simple override to make a @protected method public #3482

merged 3 commits into from
Jun 30, 2022

Conversation

srawlins
Copy link
Member

Description

Allow a simple override to make a @Protected method public.

Fixes #3475

@srawlins srawlins requested a review from bwilkerson June 30, 2022 01:08
@coveralls
Copy link

coveralls commented Jun 30, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 95.698% when pulling 7b86276 on fix-3475 into fac289e on master.

bwilkerson
bwilkerson approved these changes Jun 30, 2022
View reviewed changes
lib/src/rules/unnecessary_overrides.dart Outdated Show resolved Hide resolved
@srawlins srawlins merged commit 4cafaa6 into master Jun 30, 2022
@srawlins srawlins deleted the fix-3475 branch June 30, 2022 18:28
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
@srawlins
Allow a simple override to make a @Protected method public (dart-lang…
0a93e90 
…/linter#3482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unnecessary_override reports method M when super method is @protected and M is not
3 participants
@srawlins @coveralls @bwilkerson